Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AWS Execution duration #3032

Merged
merged 3 commits into from
Nov 12, 2020
Merged

fix: AWS Execution duration #3032

merged 3 commits into from
Nov 12, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Nov 5, 2020

No description provided.

@HazAT HazAT requested a review from lobsterkatie November 5, 2020 13:10
@HazAT HazAT requested a review from kamilogorek as a code owner November 5, 2020 13:10
@HazAT HazAT self-assigned this Nov 5, 2020
@HazAT HazAT changed the title fix: Execution duration fix: AWS Execution duration Nov 5, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2020 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 19.72 KB (0%)
@sentry/browser - Webpack 20.58 KB (0%)
@sentry/react - Webpack 20.58 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 26.86 KB (0%)

lobsterkatie
lobsterkatie approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any tests covering this to which you could easily add a check for this?

Otherwise, LGTM.

@lobsterkatie @Sija
fix typo
7d040b7 
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
@HazAT HazAT merged commit 4b20bfb into master Nov 12, 2020
@HazAT HazAT deleted the fix/aws/execution-duration branch November 12, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobsterkatie lobsterkatie lobsterkatie approved these changes

@Sija Sija Sija left review comments

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees

@HazAT HazAT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HazAT @Sija @kamilogorek @lobsterkatie